Add full fledged visual e-mail editor #2373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I'm not a dev or anything, but I use listmonk often and wanted to use emailbuilder-js before, and this is a great idea, but emailbuilder is not responsive, or at least not the version on GitHub, could that be fixed in the integration? |
knadh
force-pushed
the
feat-visual-editor
branch
4 times, most recently
from
ba5e77b to
c264c3b
Compare
- Add email-builder source - Update yarn lock
- Disable visual templates from being made default. - Refactor visual template selection flow in campaigns. - Hide scroll if templates modal is active. This is to make sure it doesn't flicker when adding blocks in visual-editor.
- Fix merge conflicts. - Simply logic in campaign preview handler. - Remove redundant `GetCampaignForPreviewWithTemplate()` and switch to the old query that optionally takes a template. - Fix Vue linting issues.
- Simplify and fix content conversion between formats. - Fix state management issues. - Rename `Apply` to `Import` on the visual template UI.
…l campaign import.
Unfortunately, the tiny CodeFlask lib stopped getting updates 5+ years ago and is buggy. The attempt to replace it with CodeInput (which itself seems to have several open bugs) failed. So, biting the bullet with CodeMirror, which is a robust, battle tested, albeit large (~300KB) code editor library. This patch replaces all code editor UIs (Campaign, Templates, Settings) with CodeMirror.
knadh
force-pushed
the
feat-visual-editor
branch
from
c264c3b to
b67fc5e
Compare
|
The merge we need! Thanks a lot! |
|
Thanks @unit1g!! This will really help us. 🔥🧡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates email-builder-js, a drag-and-drop visual template editor, into campaign and templates.